Exclusive Lists: Difference between revisions

From neuromatch
No edit summary
No edit summary
Line 53: Line 53:
So for the sake of us learning to write tests here, I don't think we need to aim for full adversarial coverage of the feature, but just get the basics: "when an account is in an exclusive list, their posts dont show up on the home feed." judging from the other tests, it looks like we'll have to also test for boosts from them, but since it's not like a block we don't have to test a bunch of edge cases like interactions.
So for the sake of us learning to write tests here, I don't think we need to aim for full adversarial coverage of the feature, but just get the basics: "when an account is in an exclusive list, their posts dont show up on the home feed." judging from the other tests, it looks like we'll have to also test for boosts from them, but since it's not like a block we don't have to test a bunch of edge cases like interactions.
|Link=https://discord.com/channels/1049136631065628772/1086754322433450075/1086768028085141535
|Link=https://discord.com/channels/1049136631065628772/1086754322433450075/1086768028085141535
}}{{Message
|Author=sneakers-the-rat
|Avatar=https://cdn.discordapp.com/avatars/305044217393053697/2970b22bd769d0cd0ee1de79be500e85.png?size=1024
|Date Sent=23-05-20 05:46:32
|Channel=techwg-ops
|Text=[[Tech WG/Ops Diary#23-05-19]]: We are attempting to [[Upgrade Mastodon]] to 4.1.2 and also merge in [[Exclusive Lists]], wish us luck.
We begin with what is probably the worst way to do it based on the conversation in <#1049184335514828860> , specifically:
* main -> dev,
* upstream -> dev,
* dev -> pr,
* pr -> dev,
* dev -> main
https://discord.com/channels/1049136631065628772/1049184335514828860/1109355378178789396
|Link=https://discord.com/channels/1049136631065628772/1052452072806686751/1109356466130931765
}}
}}

Revision as of 01:46, 20 May 2023

Exclusive Lists
Description Accounts on lists marked as exclusive do not appear on the home feed
Part Of Mastodon/Hacking
Contributors Lina, Jonny
Has Git Repository https://github.com/NeuromatchAcademy/mastodon
Completion Status Draft
Active Status Active
Approval Status Provisional


Description

(fuller description of the feature)

TODO

  • Description
  • Screenshots of the option toggle
  • Instructions on how to use???????

Discord

sneakers-the-rat#testing23-03-18 21:48:09

@lina gathering some stuff here: Mastodon/Tests Mastodon/Tech WG Exclusive Lists Ruby Spec Ruby spec for home feed: https://github.com/NeuromatchAcademy/mastodon/blob/main/spec/models/home_feed_spec.rb for public feed: https://github.com/NeuromatchAcademy/mastodon/blob/main/spec/models/public_feed_spec.rb that gives more examples on how feeds are supposed to be filtered tag feed: https://github.com/NeuromatchAcademy/mastodon/blob/main/spec/models/tag_feed_spec.rb in case we might want to add exclusive tag feeds (I personally do, self interested bc monsterdon lol) account filter (looks like for blocks): https://github.com/NeuromatchAcademy/mastodon/blob/main/spec/models/account_statuses_filter_spec.rb

and so on

the question to me is basically how these things are structured: you have some fabricator steps that set up the conditions for the test, but then you also have these `context` statements that looks like plain English strings to me? like how do those and the `describe` fields map onto the code? like is their testing system so good that you can really just write `it {is_expected.to be_filtered }` and that just works???? or how do you define all those.

Also u mentioned they are using a separate JavaScript testing framework? Jest ? that looks like it's configured here: https://github.com/NeuromatchAcademy/mastodon/blob/main/jest.config.js and doesn't cover the glitch flavours, just the mastodon folder. it seems like that is for testing the appearance and function of the JS? not sure how it interacts with the ruby tests.

So for the sake of us learning to write tests here, I don't think we need to aim for full adversarial coverage of the feature, but just get the basics: "when an account is in an exclusive list, their posts dont show up on the home feed." judging from the other tests, it looks like we'll have to also test for boosts from them, but since it's not like a block we don't have to test a bunch of edge cases like interactions.

sneakers-the-rat#techwg-ops23-05-20 05:46:32

Tech WG/Ops Diary#23-05-19: We are attempting to Upgrade Mastodon to 4.1.2 and also merge in Exclusive Lists, wish us luck.

We begin with what is probably the worst way to do it based on the conversation in <#1049184335514828860> , specifically:

  • main -> dev,
  • upstream -> dev,
  • dev -> pr,
  • pr -> dev,
  • dev -> main

https://discord.com/channels/1049136631065628772/1049184335514828860/1109355378178789396