Hack Merging Policy: Difference between revisions

From neuromatch
No edit summary
No edit summary
 
Line 16: Line 16:
[[Mastodon/Tech WG#TODO]]
[[Mastodon/Tech WG#TODO]]
|Link=https://discord.com/channels/1049136631065628772/1049184335514828860/1059601450793173042
|Link=https://discord.com/channels/1049136631065628772/1049184335514828860/1059601450793173042
}}{{Message
|Author=sneakers-the-rat
|Avatar=https://cdn.discordapp.com/avatars/305044217393053697/2970b22bd769d0cd0ee1de79be500e85.png?size=1024
|Date Sent=23-01-02 22:39:57
|Channel=technical-wg
|Text=<@863052667857534996> do y'all have anything like this for the pyopensci stuff? like a "make a feature branch off dev, make a pull request back to dev, during a code review, look for xyz" then we will also need stuff like how to do the merge and update the instance [[Hack Merging Policy]] [[Updating Mastodon]] [[Code Review]]
|Link=https://discord.com/channels/1049136631065628772/1049184335514828860/1059601974028423230
}}
}}

Latest revision as of 18:39, 2 January 2023

Discord

sneakers-the-rat#technical-wg22-12-27 19:53:46
sneakers-the-rat#technical-wg23-01-02 22:37:52

<@540104559079456770> I think you should have permissions to do a code review on the PR itself, do you know how to do one of those? we should add that to the Hack Merging Policy - a guide on how to do code review. Mastodon/Tech WG#TODO

sneakers-the-rat#technical-wg23-01-02 22:39:57

<@863052667857534996> do y'all have anything like this for the pyopensci stuff? like a "make a feature branch off dev, make a pull request back to dev, during a code review, look for xyz" then we will also need stuff like how to do the merge and update the instance Hack Merging Policy Updating Mastodon Code Review